fix: removed unefficient AI generated call pattern using one-use object types created for 2-3 variable passing.

src/cli/commands/get-token.ts

@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: MIT
 
-import { acquireResourceTokenFromLogin } from "../../azure/index.ts";
+import { acquireResourceToken } from "../../azure/index.ts";
 import { getDevOpsApiToken } from "../../devops/index.ts";
 import { loadConfig } from "../../index.ts";
 
@@ -22,11 +22,11 @@ export async function runGetTokenCommand(values: CommandValues): Promise<unknown
   const config = await loadConfig("public-config");
 
   if (tokenType === "azurerm") {
-    const result = await acquireResourceTokenFromLogin({
-      tenantId: config.tenantId,
-      clientId: config.clientId,
-      resource: "arm",
-    });
+    const result = await acquireResourceToken(
+      config.tenantId,
+      config.clientId,
+      "arm",
+    );
 
     const accessToken = result?.accessToken;
     if (!accessToken) {

src/cli/commands/list-apps.ts

@@ -16,10 +16,7 @@ Options:
 
 export async function runListAppsCommand(values: CommandValues): Promise<unknown> {
   const { client } = await getGraphClientFromPublicConfig();
-  let result = await listApps(client, {
-    displayName: values["display-name"],
-    appId: values["app-id"],
-  });
+  let result = await listApps(client, values["display-name"], values["app-id"]);
   if (values["app-id"] && result.length > 1) {
     throw new Error(`Expected a single app for --app-id ${values["app-id"]}, but got ${result.length}`);
   }

src/cli/commands/list-resource-permissions.ts

@@ -23,10 +23,11 @@ export async function runListResourcePermissionsCommand(values: CommandValues):
   }
 
   const { client } = await getGraphClientFromPublicConfig();
-  let result = await listResourcePermissions(client, {
-    appId: values["app-id"],
-    displayName: values["display-name"],
-  });
+  let result = await listResourcePermissions(
+    client,
+    values["app-id"],
+    values["display-name"],
+  );
   if (values.filter) {
     result = filterByPermissionName(result, values.filter);
   }

src/cli/commands/login.ts

@@ -18,13 +18,13 @@ Options:
 
 export async function runLoginCommand(values: CommandValues): Promise<unknown> {
   const config = await loadConfig("public-config");
-  return login({
-    tenantId: config.tenantId,
-    clientId: config.clientId,
-    resourcesCsv: values.resources,
-    useDeviceCode: Boolean(values["use-device-code"]),
-    noBrowser: Boolean(values["no-browser"]),
-    browser: values.browser,
-    browserProfile: values["browser-profile"],
-  });
+  return login(
+    config.tenantId,
+    config.clientId,
+    values.resources,
+    Boolean(values["use-device-code"]),
+    Boolean(values["no-browser"]),
+    values.browser,
+    values["browser-profile"],
+  );
 }

src/cli/commands/logout.ts

@@ -14,9 +14,5 @@ Options:
 
 export async function runLogoutCommand(values: CommandValues): Promise<unknown> {
   const config = await loadConfig("public-config");
-  return logout({
-    tenantId: config.tenantId,
-    clientId: config.clientId,
-    clearAll: Boolean(values.all),
-  });
+  return logout(config.tenantId, config.clientId, Boolean(values.all));
 }

src/cli/commands/rest.ts

@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: MIT
 
-import { acquireResourceTokenFromLogin } from "../../azure/index.ts";
+import { acquireResourceToken } from "../../azure/index.ts";
 import { getDevOpsApiToken } from "../../devops/index.ts";
 import { loadConfig } from "../../index.ts";
 
@@ -57,11 +57,11 @@ async function getAutoAuthorizationHeader(url: URL): Promise<string | null> {
   const config = await loadConfig("public-config");
 
   if (host === "management.azure.com") {
-    const result = await acquireResourceTokenFromLogin({
-      tenantId: config.tenantId,
-      clientId: config.clientId,
-      resource: "arm",
-    });
+    const result = await acquireResourceToken(
+      config.tenantId,
+      config.clientId,
+      "arm",
+    );
     const accessToken = result?.accessToken;
     if (!accessToken) {
       throw new Error("Failed to obtain AzureRM token");

src/cli/commands/shared.ts

@@ -29,8 +29,5 @@ export function filterByDisplayName<T extends DisplayNameRow>(rows: T[], pattern
 
 export async function getGraphClientFromPublicConfig(): Promise<{ client: any }> {
   const config = await loadConfig("public-config");
-  return getGraphClient({
-    tenantId: config.tenantId,
-    clientId: config.clientId,
-  });
+  return getGraphClient(config.tenantId, config.clientId);
 }