fix: removed unefficient AI generated call pattern using one-use object types created for 2-3 variable passing.

src/azure/client-auth.ts

@@ -1,18 +1,16 @@
 // SPDX-License-Identifier: MIT
 
 import { DefaultAzureCredential, ClientSecretCredential, DeviceCodeCredential } from "@azure/identity";
+import type { AuthenticationResult } from "@azure/msal-node";
+import { acquireResourceToken as acquireResourceTokenPca } from "./pca-auth.ts";
 
 type CredentialType = "d" | "default" | "cs" | "clientSecret" | "dc" | "deviceCode";
 
-type CredentialOptions = {
-  tenantId?: string;
-  clientId?: string;
-  clientSecret?: string;
-};
-
 export async function getCredential(
   credentialType: CredentialType,
-  options: CredentialOptions,
+  tenantId?: string,
+  clientId?: string,
+  clientSecret?: string,
 ): Promise<DefaultAzureCredential | ClientSecretCredential | DeviceCodeCredential> {
   switch (credentialType) {
     case "d":
@@ -20,26 +18,26 @@ export async function getCredential(
       return new DefaultAzureCredential();
     case "cs":
     case "clientSecret":
-      if (!options.tenantId || !options.clientId || !options.clientSecret) {
+      if (!tenantId || !clientId || !clientSecret) {
         throw new Error(
           "tenantId, clientId, and clientSecret are required for ClientSecretCredential",
         );
       }
       return new ClientSecretCredential(
-        options.tenantId,
-        options.clientId,
-        options.clientSecret,
+        tenantId,
+        clientId,
+        clientSecret,
       );
     case "dc":
     case "deviceCode":
-      if (!options.tenantId || !options.clientId) {
+      if (!tenantId || !clientId) {
         throw new Error(
           "tenantId and clientId are required for DeviceCodeCredential",
         );
       }
       return new DeviceCodeCredential({
-        tenantId: options.tenantId,
-        clientId: options.clientId,
+        tenantId,
+        clientId,
         userPromptCallback: (info) => {
           console.log(info.message);
         },
@@ -48,3 +46,11 @@ export async function getCredential(
       throw new Error(`Unsupported credential type: ${credentialType}`);
   }
 }
+
+export async function acquireResourceToken(
+  tenantId: string,
+  clientId: string,
+  resource: string,
+): Promise<AuthenticationResult | null> {
+  return acquireResourceTokenPca(tenantId, clientId, resource);
+}