feature: Caddy serves static web sites from folders on the router, defined in their own database, with files uploaded through the web service or WebDAV, and an optional PowerDNS name server answers for a zone of the sites.

debian-package/src/usr/lib/vpn-router/vpnrouter_users.py

@@ -23,8 +23,9 @@ user who is not a service account when there are none.
 A group is a groupOfNames in ou=groups with a name, which follows the rules of user names, an
 optional description and at least one member; a group cannot be empty, so the last member
 cannot leave it and a user who is the last member of a group cannot be removed. ADMIN_GROUP grants the management of
-the router, and the allowed groups of the OpenID Provider's clients who may sign in to them; renaming a group renames it
-in those, and a group a client allows cannot be removed.
+the router, the allowed groups of the OpenID Provider's clients who may sign in to them, and the editors group of a web
+site who may change its files (vpnrouter_sites); renaming a group renames it in those, and a group a client allows or a
+site has cannot be removed.
 
 A VPN user may have WireGuard peers, each a device with its public key and its IPs, in
 vpnRouterWireGuardPeer; vpn-router-setup writes a [Peer] of wg0.conf for each peer of a user who
@@ -896,7 +897,8 @@ def group_add(connection, name, description, members):
 def group_update(connection, name, new_name=None, description=None):
     """Rename the group or change its description ('' removes it); at least one must be given. Renaming ADMIN_GROUP
     switches the console login of its members off; renaming a group a client of the OpenID Provider allows renames it
-    there."""
+    there, and renaming the editors group of web sites renames it in the sites."""
+    import vpnrouter_sites
     if new_name is None and description is None:
         raise Failure('give a new name or a description', 2)
     members = member_names(group_entry(connection, name))
@@ -914,6 +916,10 @@ def group_update(connection, name, new_name=None, description=None):
         for client in allowing(connection, name):
             connection.modify_s(dn_of(client), [(ldap.MOD_DELETE, 'vpnRouterAllowedGroup', [group_dn(name).encode()]),
                                                 (ldap.MOD_ADD, 'vpnRouterAllowedGroup', [group_dn(new_name).encode()])])
+        try:
+            vpnrouter_sites.rename_group(name, new_name)
+        except vpnrouter_sites.DatabaseError as exc:
+            raise Failure(f'group {name} is renamed {new_name}, but not in the web sites: {exc}')
         if name == ADMIN_GROUP:
             console_off(connection, members)
         name = new_name
@@ -921,12 +927,19 @@ def group_update(connection, name, new_name=None, description=None):
 
 
 def group_remove(connection, name):
-    """Remove the group, unless a client of the OpenID Provider allows it; removing ADMIN_GROUP switches the console login
-    of its members off."""
+    """Remove the group, unless a client of the OpenID Provider allows it or it is the editors group of web sites;
+    removing ADMIN_GROUP switches the console login of its members off."""
+    import vpnrouter_sites
     members = member_names(group_entry(connection, name))
     clients = allowing(connection, name)
     if clients:
         raise Failure(f'group {name} is an allowed group of the clients {", ".join(clients)}; take it out of them first', 2)
+    try:
+        sites = vpnrouter_sites.sites_of_group(name)
+    except vpnrouter_sites.DatabaseError as exc:
+        raise Failure(f'the web sites cannot be read: {exc}')
+    if sites:
+        raise Failure(f'group {name} is the editors group of the web sites {", ".join(sites)}; change them first', 2)
     connection.delete_s(group_dn(name))
     if name == ADMIN_GROUP:
         console_off(connection, members)