feature: Caddy serves static web sites from folders on the router, defined in their own database, with files uploaded through the web service or WebDAV, and an optional PowerDNS name server answers for a zone of the sites.

debian-package/src/usr/lib/vpn-router/vpnrouter_backup.py

@@ -1,9 +1,10 @@
 """The backups of the router, for vpn-router-backup and the web service.
 
 A backup is a consistent copy of the state that setup cannot make again, staged in STAGING: the
-trees of TREES, the files of site_to_site psk_file outside them under files/, the directory as
-slapcat writes it (ldap/vpn-router.ldif), with backup.metrics the database as pg_dump writes it
-(postgresql/vpn-router.dump), and manifest.json. The trees and the directory are copied while
+trees of TREES, the folders of the web sites among them, the files of site_to_site psk_file outside them under files/,
+the directory as slapcat writes it (ldap/vpn-router.ldif), with backup.metrics the database as pg_dump writes it
+(postgresql/vpn-router.dump), the databases of the web sites and of the name server (DUMPS) once they exist, and
+manifest.json. The trees and the directory are copied while
 the configuration lock and the users lock are held, so the configuration, the PKI and the users
 match; pg_dump reads a snapshot of its own.
 
@@ -33,7 +34,9 @@ import time
 
 import vpnrouter
 import vpnrouter_auth
+import vpnrouter_dns
 import vpnrouter_ldap
+import vpnrouter_sites
 import vpnrouter_users
 
 STATE = pathlib.Path('/var/lib/vpn-router/backup.json')
@@ -49,7 +52,12 @@ UNIT = 'vpn-router-backup.service'
 TIMER = 'vpn-router-backup.timer'
 
 #: The state a backup copies: directories and files, each where it is on the system.
-TREES = ('/etc/vpn-router', '/etc/wireguard', '/etc/ufw', '/etc/default/ufw', '/etc/vpn-router-manager')
+TREES = ('/etc/vpn-router', '/etc/wireguard', '/etc/ufw', '/etc/default/ufw', '/etc/vpn-router-manager',
+         str(vpnrouter_sites.SITES_DIR))
+
+#: The databases a backup always dumps, each while it exists: the dump -> the database and its password file.
+DUMPS = {'postgresql/vpn-router-sites.dump': (vpnrouter_sites.DATABASE, vpnrouter_sites.DATABASE_SECRET),
+         'postgresql/vpn-router-dns.dump': (vpnrouter_dns.DATABASE, vpnrouter_dns.DATABASE_SECRET)}
 
 #: The name of a local archive: the host and the UTC time of the backup.
 ARCHIVE = re.compile(r'^vpn-router-(?P<host>[A-Za-z0-9][A-Za-z0-9.-]*)-(?P<stamp>\d{8}T\d{6}Z)\.tar\.zst$')
@@ -64,7 +72,8 @@ PERIODS = {'keep_hourly': '%Y-%m-%d %H', 'keep_daily': '%Y-%m-%d', 'keep_weekly'
            'keep_yearly': '%Y'}
 
 #: The units a restore stops while it replaces the directory and the database, and the ones it restarts after setup.
-RESTORE_STOPS = ('vpn-router-web.service', 'vpn-router-metrics.service', 'slapd.service')
+RESTORE_STOPS = ('vpn-router-web.service', 'vpn-router-metrics.service', 'vpn-router-webdav.service', 'pdns.service',
+                 'slapd.service')
 RESTORE_RESTARTS = ('wg-quick@wg0.service', 'openvpn-server@vpn-router.service', 'strongswan.service',
                     'vpn-router-manager.service')
 
@@ -223,14 +232,16 @@ def stage(cfg):
         (STAGING / LDIF).parent.mkdir()
         command(['slapcat', '-b', vpnrouter_ldap.BASE, '-l', str(STAGING / LDIF)])
     items = trees + [f'files{name}' for name in files] + [LDIF]
-    if cfg['backup']['metrics']:
-        (STAGING / DUMP).parent.mkdir()
-        prefix, database = database_args(cfg)
-        with open(STAGING / DUMP, 'wb') as dump:
+    dumps = {**({DUMP: database_args(cfg)} if cfg['backup']['metrics'] else {}),
+             **{item: (['runuser', '-u', 'postgres', '--'], [f'--dbname={name}'])
+                for item, (name, secret) in DUMPS.items() if secret.is_file()}}
+    for item, (prefix, database) in dumps.items():
+        (STAGING / item).parent.mkdir(exist_ok=True)
+        with open(STAGING / item, 'wb') as dump:
             result = subprocess.run([*prefix, 'pg_dump', '-Fc', *database], stdout=dump, stderr=subprocess.PIPE)
         if result.returncode != 0:
-            raise Failure(f'pg_dump failed: {result.stderr.decode(errors="replace").strip()}')
-        items.append(DUMP)
+            raise Failure(f'pg_dump for {item} failed: {result.stderr.decode(errors="replace").strip()}')
+        items.append(item)
     version = subprocess.run(['dpkg-query', '-W', '-f=${Version}', 'vpn-router'], capture_output=True, text=True)
     manifest = {'host': host(), 'time': now(), 'version': version.stdout.strip() or None,
                 'schedule': cfg['backup']['schedule'], 'items': items}
@@ -389,19 +400,22 @@ def restore(source, pbs, confirm):
             subprocess.run(['systemctl', 'start', 'slapd.service'], capture_output=True)
             restored = vpnrouter.load_config()
             if not restored['web']['database'].strip():
-                secret = vpnrouter_auth.DATABASE_SECRET
-                if secret.is_file() and vpnrouter_auth.psql("SELECT 1 FROM pg_roles WHERE rolname = :'v1'",
-                                                            vpnrouter_auth.DATABASE):
-                    password = secret.read_text(encoding='utf-8').strip()
-                    vpnrouter_auth.psql(f"ALTER ROLE :\"v1\" PASSWORD '{password}'", vpnrouter_auth.DATABASE)
+                vpnrouter_auth.reset_password(vpnrouter_auth.DATABASE, vpnrouter_auth.DATABASE_SECRET)
                 vpnrouter_auth.provision(restored)
-            if DUMP in manifest['items']:
-                prefix, database = database_args(restored)
-                with open(RESTORE_DIR / DUMP, 'rb') as dump:
+            dumps = {DUMP: database_args(restored)}
+            for item, (name, secret) in DUMPS.items():
+                if item in manifest['items']:
+                    vpnrouter_auth.reset_password(name, secret)
+                    vpnrouter_auth.provision_database(name, secret)
+                    dumps[item] = (['runuser', '-u', 'postgres', '--'], [f'--dbname={name}'])
+            for item, (prefix, database) in dumps.items():
+                if item not in manifest['items']:
+                    continue
+                with open(RESTORE_DIR / item, 'rb') as dump:
                     result = subprocess.run([*prefix, 'pg_restore', '--clean', '--if-exists', *database], stdin=dump,
                                             stdout=subprocess.DEVNULL, stderr=subprocess.PIPE)
                 if result.returncode != 0:
-                    raise Failure(f'pg_restore failed: {result.stderr.decode(errors="replace").strip()}')
+                    raise Failure(f'pg_restore of {item} failed: {result.stderr.decode(errors="replace").strip()}')
             subprocess.run(['systemctl', 'start', 'vpn-router-web.service'], capture_output=True)
             command(['systemctl', 'restart', 'vpn-router-setup.service'])
             for unit in RESTORE_RESTARTS: