slawek/azure-acme-provisioner
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: rename command argument from 'domain' to 'fqdn' for clarity

Browse Source
This commit is contained in:
Sławek Koszewski
2026-05-22 12:25:08 +02:00
parent ea2a68a7dd
commit 25d85ed23f
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
package-lock.json
Generated
+2 -2
View File
@@ -1,12 +1,12 @@
{ {
"name": "azure-acme-provisioner", "name": "azure-acme-provisioner",
"version": "0.4.3", "version": "0.4.4",
"lockfileVersion": 3, "lockfileVersion": 3,
"requires": true, "requires": true,
"packages": { "packages": {
"": { "": {
"name": "azure-acme-provisioner", "name": "azure-acme-provisioner",
"version": "0.4.3", "version": "0.4.4",
"license": "MIT", "license": "MIT",
"dependencies": { "dependencies": {
"@azure/arm-authorization": "^9.0.0", "@azure/arm-authorization": "^9.0.0",
package.json
+1 -1
View File
@@ -1,6 +1,6 @@
{ {
"name": "azure-acme-provisioner", "name": "azure-acme-provisioner",
"version": "0.4.3", "version": "0.4.4",
"author": { "author": {
"name": "Sławomir Koszewski", "name": "Sławomir Koszewski",
"url": "https://github.com/skoszewski" "url": "https://github.com/skoszewski"
src/cli.ts
+3 -3
View File
@@ -134,12 +134,12 @@ sharedOptions(
sharedOptions( sharedOptions(
program program
.command('assign-role <domain>') .command('assign-role <fqdn>')
.description('Assign Key Vault Certificate User and Secrets User roles to a principal for a domain certificate') .description('Assign Key Vault Certificate User and Secrets User roles to a principal for a domain certificate')
.requiredOption('--principal-id <id>', 'Azure principal ID to assign roles to') .requiredOption('--principal-id <id>', 'Azure principal ID to assign roles to')
.requiredOption('--principal-type <type>', 'Principal type: User | Group | ServicePrincipal (use ServicePrincipal for managed identities)') .requiredOption('--principal-type <type>', 'Principal type: User | Group | ServicePrincipal (use ServicePrincipal for managed identities)')
.option('--dry-run', 'Show what would be assigned without making changes') .option('--dry-run', 'Show what would be assigned without making changes')
).action(async (domain: string, options: Record<string, unknown>) => { ).action(async (fqdn: string, options: Record<string, unknown>) => {
applyOverrides(options); applyOverrides(options);
const config = loadConfig(); const config = loadConfig();
if (!config.subscriptionId) throw new Error('--subscription-id is required'); if (!config.subscriptionId) throw new Error('--subscription-id is required');
@@ -151,7 +151,7 @@ sharedOptions(
const principalId = String(options['principalId']); const principalId = String(options['principalId']);
const principalType = String(options['principalType']) as 'User' | 'Group' | 'ServicePrincipal'; const principalType = String(options['principalType']) as 'User' | 'Group' | 'ServicePrincipal';
const vaultName = new URL(config.keyVaultUrl).hostname.split('.')[0]; const vaultName = new URL(config.keyVaultUrl).hostname.split('.')[0];
const certName = domainToCertName(domain); const certName = domainToCertName(fqdn);
const vaultBase = `/subscriptions/${sub}/resourceGroups/${kvRg}/providers/Microsoft.KeyVault/vaults/${vaultName}`; const vaultBase = `/subscriptions/${sub}/resourceGroups/${kvRg}/providers/Microsoft.KeyVault/vaults/${vaultName}`;
const credential = new DefaultAzureCredential(); const credential = new DefaultAzureCredential();
const authClient = new AuthorizationManagementClient(credential, sub); const authClient = new AuthorizationManagementClient(credential, sub);