From 59f0f68a94f010884131e9733e4cf9d0f3b052f3 Mon Sep 17 00:00:00 2001 From: Slawomir Koszewski Date: Sat, 16 May 2026 22:59:08 +0200 Subject: [PATCH] Refactor render_env_page and _on_domain_change functions for improved clarity and functionality --- scripts/accounts_editor.py | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/scripts/accounts_editor.py b/scripts/accounts_editor.py index fb36cf3..298ca45 100755 --- a/scripts/accounts_editor.py +++ b/scripts/accounts_editor.py @@ -114,6 +114,7 @@ def _on_domain_change(domain_key: str, base_dn_key: str) -> None: st.session_state[base_dn_key] = _domain_to_dn(domain) + def write_env(path: Path, values: dict[str, str]) -> None: path.parent.mkdir(parents=True, exist_ok=True) with path.open("w", encoding="utf-8") as f: @@ -147,20 +148,18 @@ def render_env_page(data_dir: Path) -> None: if wkey not in st.session_state: raw = st.session_state[saved_key].get(var, "") st.session_state[wkey] = raw == "1" if var == "KERBEROS_ENABLE" else raw - col_label, col_input = st.columns([1, 2], width=480, vertical_alignment="center") - col_label.markdown(label) if var == "KERBEROS_ENABLE": - col_input.toggle(label, key=wkey, label_visibility="collapsed") + st.toggle(label, key=wkey, width=480) else: extra = ( {"on_change": _on_domain_change, "args": (wkey, widget_key("LDAP_BASE_DN"))} if var == "LDAP_DOMAIN" else {} ) - col_input.text_input( + st.text_input( label, key=wkey, type="password" if var.endswith("_PASSWORD") else "default", - label_visibility="collapsed", + width=480, **extra, ) @@ -235,7 +234,7 @@ def main() -> None: page_name = st.radio("Page", [ENV_PAGE] + list(FILES.keys())) data_dir = Path(data_dir_raw).expanduser() - st.caption("This editor manages the CSV files used by OpenLDAP bootstrap.") + st.caption("This editor manages configuration files used by OpenLDAP bootstrap.") if page_name == ENV_PAGE: if not data_dir.exists():